Skip to content

Add ml.update_trained_model_deployment API #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

pquentin
Copy link
Member

I'm not sure if it should be added or not, as this API is currently in beta.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.update_trained_model_deployment 🔴 2/3 0/3

You can validate these APIs yourself by using the make validate target.

@davidkyle
Copy link
Member

Elasticsearch is updated to make this API GA in elastic/elasticsearch#108868

The same PR also adds number_of_allocations as a query param

@pquentin
Copy link
Member Author

@davidkyle What are your thoughts on merging this now, and then updating when the query parameters are available? For clients this makes no difference, the usage is the same.

@davidkyle
Copy link
Member

The PR that adds the query param (elastic/elasticsearch#108868) is now merged, can the query param be added now?

@davidkyle
Copy link
Member

The API spec still says beta and needs updating from the ES repo.

@pquentin
Copy link
Member Author

I was thinking we could reflect the current reality in order to ship that today in 8.13, and then when 8.14.1 goes out we can update with the beta label and query parameters.

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle
Copy link
Member

I was thinking we could reflect the current reality in order to ship that today in 8.13,

👍 I added the backport 8.13 label

@pquentin pquentin merged commit 4195183 into main May 24, 2024
8 checks passed
@pquentin pquentin deleted the update-trained-models branch May 24, 2024 10:54
github-actions bot pushed a commit that referenced this pull request May 24, 2024
github-actions bot pushed a commit that referenced this pull request May 24, 2024
pquentin added a commit that referenced this pull request May 24, 2024
(cherry picked from commit 4195183)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
pquentin added a commit that referenced this pull request May 24, 2024
(cherry picked from commit 4195183)

Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants