-
Notifications
You must be signed in to change notification settings - Fork 101
Add ml.update_trained_model_deployment API #2564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Elasticsearch is updated to make this API GA in elastic/elasticsearch#108868 The same PR also adds |
@davidkyle What are your thoughts on merging this now, and then updating when the query parameters are available? For clients this makes no difference, the usage is the same. |
The PR that adds the query param (elastic/elasticsearch#108868) is now merged, can the query param be added now? |
The API spec still says elasticsearch-specification/specification/_json_spec/ml.update_trained_model_deployment.json Line 7 in e54499c
|
I was thinking we could reflect the current reality in order to ship that today in 8.13, and then when 8.14.1 goes out we can update with the beta label and query parameters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👍 I added the backport 8.13 label |
(cherry picked from commit 4195183)
(cherry picked from commit 4195183)
I'm not sure if it should be added or not, as this API is currently in beta.